New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch zmq -> zeromq, msgpack -> msgpack-lite #84

Merged
merged 2 commits into from Jun 20, 2018

Conversation

Projects
None yet
6 participants
@fyears
Contributor

fyears commented Feb 18, 2017

I was trying zerorpc in Windows, it's VERY annoying to configure the node-gyp / C++ compiler environment.

Then I tried to find the alternatives: zeromq.js is a better alternative to zeromq.node, and most importantly it provides prebuilt binaries for all major platforms! No need to install c++ compilers!

Similarly, msgpack-lite is a pure js alternative to msgpack using c++ codes. It claims to be faster than msgpack.

npm test seems to have no problems.

@stanleyxu2005

This comment has been minimized.

stanleyxu2005 commented Mar 22, 2017

Sorry. I did not notice that you have provide a PR as well. The only difference between yours and mine, is I have not changed zmq to zeromq. No idea, whether this change is really necessary. zeromq is a new module. I'm not pretty sure there is good reason to switch

@fyears

This comment has been minimized.

Contributor

fyears commented Mar 22, 2017

zeromq is under more active maintenance, and most importantly it provides pre-compiled binaries under different platforms (especially, Windows!), which means we even don't need a C++ compiler any more if everything goes well.

Under the hook, zmq and zeromq have insignificant differences.

@medanat

This comment has been minimized.

medanat commented Jan 12, 2018

It would be great to get this merged in given zmq is no longer maintained.

@dayfine

This comment has been minimized.

dayfine commented Feb 6, 2018

Could someone review and maybe approve this PR?

I have problem getting the origin repo to work, as msgPack throwing me an error about not being able to find its node binding...maybe c++ thing. Solved with this fork.

@qyloxe

This comment has been minimized.

qyloxe commented Feb 26, 2018

Can this PR be merged? Please? :-)
On windows installing zerorpc-node is a nightmare. With this little change to zeromq it just works.

Interesting - Python vs Node benchmark (Windows 7):
pyserver <- pyclient (10000 hello requests) = 11 seconds
nodeserver <- pyclient (10000 hello requests) = 45 seconds

@bombela bombela merged commit 7bff241 into 0rpc:master Jun 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment