Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from deprecated nose to pytest (solves #243) #247

Merged
merged 1 commit into from
Jan 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ script:
- if [ $TRAVIS_PYTHON_VERSION != '2.6' ]; then
flake8 --ignore=E501,E128 zerorpc bin;
fi
- nosetests -v
- pytest -v
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@
url='https://github.com/0rpc/zerorpc-python',
packages=['zerorpc'],
install_requires=requirements,
tests_require=['nose'],
test_suite='nose.collector',
tests_require=['pytest'],
test_suite='pytest.collector',
zip_safe=False,
entry_points={'console_scripts': ['zerorpc = zerorpc.cli:main']},
license='MIT',
Expand Down
42 changes: 21 additions & 21 deletions tests/test_buffered_channel.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
from __future__ import absolute_import
from builtins import range

from nose.tools import assert_raises
import pytest
import gevent
import sys

Expand Down Expand Up @@ -61,9 +61,9 @@ def test_close_server_bufchan():
print('CLOSE SERVER SOCKET!!!')
server_bufchan.close()
if sys.version_info < (2, 7):
assert_raises(zerorpc.LostRemote, client_bufchan.recv)
pytest.raises(zerorpc.LostRemote, client_bufchan.recv)
else:
with assert_raises(zerorpc.LostRemote):
with pytest.raises(zerorpc.LostRemote):
client_bufchan.recv()
print('CLIENT LOST SERVER :)')
client_bufchan.close()
Expand Down Expand Up @@ -96,9 +96,9 @@ def test_close_client_bufchan():
print('CLOSE CLIENT SOCKET!!!')
client_bufchan.close()
if sys.version_info < (2, 7):
assert_raises(zerorpc.LostRemote, client_bufchan.recv)
pytest.raises(zerorpc.LostRemote, client_bufchan.recv)
else:
with assert_raises(zerorpc.LostRemote):
with pytest.raises(zerorpc.LostRemote):
client_bufchan.recv()
print('SERVER LOST CLIENT :)')
server_bufchan.close()
Expand Down Expand Up @@ -129,9 +129,9 @@ def test_heartbeat_can_open_channel_server_close():
print('CLOSE SERVER SOCKET!!!')
server_bufchan.close()
if sys.version_info < (2, 7):
assert_raises(zerorpc.LostRemote, client_bufchan.recv)
pytest.raises(zerorpc.LostRemote, client_bufchan.recv)
else:
with assert_raises(zerorpc.LostRemote):
with pytest.raises(zerorpc.LostRemote):
client_bufchan.recv()
print('CLIENT LOST SERVER :)')
client_bufchan.close()
Expand Down Expand Up @@ -170,9 +170,9 @@ def server_fn():
client_bufchan.close()
client.close()
if sys.version_info < (2, 7):
assert_raises(zerorpc.LostRemote, server_coro.get)
pytest.raises(zerorpc.LostRemote, server_coro.get)
else:
with assert_raises(zerorpc.LostRemote):
with pytest.raises(zerorpc.LostRemote):
server_coro.get()
print('SERVER LOST CLIENT :)')
server.close()
Expand Down Expand Up @@ -244,9 +244,9 @@ def client_do():
assert list(event.args) == [x + x * x]
client_bufchan.emit('add', (x, x * x))
if sys.version_info < (2, 7):
assert_raises(zerorpc.LostRemote, client_bufchan.recv)
pytest.raises(zerorpc.LostRemote, client_bufchan.recv)
else:
with assert_raises(zerorpc.LostRemote):
with pytest.raises(zerorpc.LostRemote):
client_bufchan.recv()
client_bufchan.close()

Expand Down Expand Up @@ -308,9 +308,9 @@ def server_do():
server_bufchan.emit('OK', (sum(event.args),))

if sys.version_info < (2, 7):
assert_raises(zerorpc.LostRemote, server_bufchan.recv)
pytest.raises(zerorpc.LostRemote, server_bufchan.recv)
else:
with assert_raises(zerorpc.LostRemote):
with pytest.raises(zerorpc.LostRemote):
server_bufchan.recv()
server_bufchan.close()

Expand Down Expand Up @@ -343,9 +343,9 @@ def _do_with_assert_raises():
event = client_bufchan.recv(timeout=TIME_FACTOR * 3)
assert event.name == 'OK'
assert list(event.args) == [x]
assert_raises(zerorpc.TimeoutExpired, _do_with_assert_raises)
pytest.raises(zerorpc.TimeoutExpired, _do_with_assert_raises)
else:
with assert_raises(zerorpc.TimeoutExpired):
with pytest.raises(zerorpc.TimeoutExpired):
for x in range(10):
client_bufchan.emit('sleep', (x,))
event = client_bufchan.recv(timeout=TIME_FACTOR * 3)
Expand All @@ -369,9 +369,9 @@ def _do_with_assert_raises():
assert event.name == 'sleep'
gevent.sleep(TIME_FACTOR * event.args[0])
server_bufchan.emit('OK', event.args)
assert_raises(zerorpc.LostRemote, _do_with_assert_raises)
pytest.raises(zerorpc.LostRemote, _do_with_assert_raises)
else:
with assert_raises(zerorpc.LostRemote):
with pytest.raises(zerorpc.LostRemote):
for x in range(20):
event = server_bufchan.recv()
assert event.name == 'sleep'
Expand Down Expand Up @@ -422,19 +422,19 @@ def server_do():
def _do_with_assert_raises():
for x in range(200):
server_bufchan.emit('coucou', x, timeout=0) # will fail when x == 1
assert_raises(zerorpc.TimeoutExpired, _do_with_assert_raises)
pytest.raises(zerorpc.TimeoutExpired, _do_with_assert_raises)
else:
with assert_raises(zerorpc.TimeoutExpired):
with pytest.raises(zerorpc.TimeoutExpired):
for x in range(200):
server_bufchan.emit('coucou', x, timeout=0) # will fail when x == 1
server_bufchan.emit('coucou', 1) # block until receiver is ready
if sys.version_info < (2, 7):
def _do_with_assert_raises():
for x in range(2, 200):
server_bufchan.emit('coucou', x, timeout=0) # will fail when x == 100
assert_raises(zerorpc.TimeoutExpired, _do_with_assert_raises)
pytest.raises(zerorpc.TimeoutExpired, _do_with_assert_raises)
else:
with assert_raises(zerorpc.TimeoutExpired):
with pytest.raises(zerorpc.TimeoutExpired):
for x in range(2, 200):
server_bufchan.emit('coucou', x, timeout=0) # will fail when x == 100
for x in range(read_cnt.value, 200):
Expand Down
6 changes: 3 additions & 3 deletions tests/test_client_async.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

from __future__ import print_function
from __future__ import absolute_import
from nose.tools import assert_raises
import pytest
import gevent
import sys

Expand Down Expand Up @@ -58,9 +58,9 @@ def add(self, a, b):
if sys.version_info < (2, 7):
def _do_with_assert_raises():
print(async_result.get())
assert_raises(zerorpc.TimeoutExpired, _do_with_assert_raises)
pytest.raises(zerorpc.TimeoutExpired, _do_with_assert_raises)
else:
with assert_raises(zerorpc.TimeoutExpired):
with pytest.raises(zerorpc.TimeoutExpired):
print(async_result.get())
client.close()
srv.close()
Expand Down
34 changes: 17 additions & 17 deletions tests/test_heartbeat.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
from __future__ import absolute_import
from builtins import range

from nose.tools import assert_raises
import pytest
import gevent
import sys

Expand Down Expand Up @@ -59,9 +59,9 @@ def test_close_server_hbchan():
print('CLOSE SERVER SOCKET!!!')
server_hbchan.close()
if sys.version_info < (2, 7):
assert_raises(zerorpc.LostRemote, client_hbchan.recv)
pytest.raises(zerorpc.LostRemote, client_hbchan.recv)
else:
with assert_raises(zerorpc.LostRemote):
with pytest.raises(zerorpc.LostRemote):
client_hbchan.recv()
print('CLIENT LOST SERVER :)')
client_hbchan.close()
Expand Down Expand Up @@ -92,9 +92,9 @@ def test_close_client_hbchan():
print('CLOSE CLIENT SOCKET!!!')
client_hbchan.close()
if sys.version_info < (2, 7):
assert_raises(zerorpc.LostRemote, server_hbchan.recv)
pytest.raises(zerorpc.LostRemote, server_hbchan.recv)
else:
with assert_raises(zerorpc.LostRemote):
with pytest.raises(zerorpc.LostRemote):
server_hbchan.recv()
print('SERVER LOST CLIENT :)')
server_hbchan.close()
Expand Down Expand Up @@ -123,9 +123,9 @@ def test_heartbeat_can_open_channel_server_close():
print('CLOSE SERVER SOCKET!!!')
server_hbchan.close()
if sys.version_info < (2, 7):
assert_raises(zerorpc.LostRemote, client_hbchan.recv)
pytest.raises(zerorpc.LostRemote, client_hbchan.recv)
else:
with assert_raises(zerorpc.LostRemote):
with pytest.raises(zerorpc.LostRemote):
client_hbchan.recv()
print('CLIENT LOST SERVER :)')
client_hbchan.close()
Expand Down Expand Up @@ -155,9 +155,9 @@ def test_heartbeat_can_open_channel_client_close():
client_hbchan.close()
client.close()
if sys.version_info < (2, 7):
assert_raises(zerorpc.LostRemote, server_hbchan.recv)
pytest.raises(zerorpc.LostRemote, server_hbchan.recv)
else:
with assert_raises(zerorpc.LostRemote):
with pytest.raises(zerorpc.LostRemote):
server_hbchan.recv()
print('SERVER LOST CLIENT :)')
server_hbchan.close()
Expand Down Expand Up @@ -227,9 +227,9 @@ def client_do():
assert list(event.args) == [x + x * x]
client_hbchan.emit('add', (x, x * x))
if sys.version_info < (2, 7):
assert_raises(zerorpc.LostRemote, client_hbchan.recv)
pytest.raises(zerorpc.LostRemote, client_hbchan.recv)
else:
with assert_raises(zerorpc.LostRemote):
with pytest.raises(zerorpc.LostRemote):
client_hbchan.recv()
client_hbchan.close()

Expand Down Expand Up @@ -287,9 +287,9 @@ def server_do():
server_hbchan.emit('OK', (sum(event.args),))

if sys.version_info < (2, 7):
assert_raises(zerorpc.LostRemote, server_hbchan.recv)
pytest.raises(zerorpc.LostRemote, server_hbchan.recv)
else:
with assert_raises(zerorpc.LostRemote):
with pytest.raises(zerorpc.LostRemote):
server_hbchan.recv()
server_hbchan.close()

Expand Down Expand Up @@ -322,9 +322,9 @@ def _do_with_assert_raises():
event = client_hbchan.recv(timeout=TIME_FACTOR * 3)
assert event.name == 'OK'
assert list(event.args) == [x]
assert_raises(zerorpc.TimeoutExpired, _do_with_assert_raises)
pytest.raises(zerorpc.TimeoutExpired, _do_with_assert_raises)
else:
with assert_raises(zerorpc.TimeoutExpired):
with pytest.raises(zerorpc.TimeoutExpired):
for x in range(10):
client_hbchan.emit('sleep', (x,))
event = client_hbchan.recv(timeout=TIME_FACTOR * 3)
Expand All @@ -346,9 +346,9 @@ def _do_with_assert_raises():
assert event.name == 'sleep'
gevent.sleep(TIME_FACTOR * event.args[0])
server_hbchan.emit('OK', event.args)
assert_raises(zerorpc.LostRemote, _do_with_assert_raises)
pytest.raises(zerorpc.LostRemote, _do_with_assert_raises)
else:
with assert_raises(zerorpc.LostRemote):
with pytest.raises(zerorpc.LostRemote):
for x in range(20):
event = server_hbchan.recv()
assert event.name == 'sleep'
Expand Down
6 changes: 3 additions & 3 deletions tests/test_middleware.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
from builtins import str
from future.utils import tobytes

from nose.tools import assert_raises
import pytest
import gevent
import gevent.local
import random
Expand Down Expand Up @@ -101,9 +101,9 @@ def hello(self):

srv = Srv(heartbeat=TIME_FACTOR * 1, context=c)
if sys.version_info < (2, 7):
assert_raises(zmq.ZMQError, srv.bind, 'some_service')
pytest.raises(zmq.ZMQError, srv.bind, 'some_service')
else:
with assert_raises(zmq.ZMQError):
with pytest.raises(zmq.ZMQError):
srv.bind('some_service')

cnt = c.register_middleware(Resolver())
Expand Down
14 changes: 7 additions & 7 deletions tests/test_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
from __future__ import absolute_import
from builtins import range

from nose.tools import assert_raises
import pytest
import gevent
import sys

Expand Down Expand Up @@ -114,9 +114,9 @@ def add(self, a, b):
client.connect(endpoint)

if sys.version_info < (2, 7):
assert_raises(zerorpc.TimeoutExpired, client.add, 1, 4)
pytest.raises(zerorpc.TimeoutExpired, client.add, 1, 4)
else:
with assert_raises(zerorpc.TimeoutExpired):
with pytest.raises(zerorpc.TimeoutExpired):
print(client.add(1, 4))
client.close()
srv.close()
Expand All @@ -140,9 +140,9 @@ def raise_something(self, a):
if sys.version_info < (2, 7):
def _do_with_assert_raises():
print(client.raise_something(42))
assert_raises(zerorpc.RemoteError, _do_with_assert_raises)
pytest.raises(zerorpc.RemoteError, _do_with_assert_raises)
else:
with assert_raises(zerorpc.RemoteError):
with pytest.raises(zerorpc.RemoteError):
print(client.raise_something(42))
assert client.raise_something(list(range(5))) == 4
client.close()
Expand All @@ -167,9 +167,9 @@ def raise_error(self):
if sys.version_info < (2, 7):
def _do_with_assert_raises():
print(client.raise_error())
assert_raises(zerorpc.RemoteError, _do_with_assert_raises)
pytest.raises(zerorpc.RemoteError, _do_with_assert_raises)
else:
with assert_raises(zerorpc.RemoteError):
with pytest.raises(zerorpc.RemoteError):
print(client.raise_error())
try:
client.raise_error()
Expand Down
4 changes: 2 additions & 2 deletions tests/testutils.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
from builtins import str

import functools
import nose.exc
import pytest
import random
import os

Expand All @@ -52,7 +52,7 @@ def skip(reason):
def _skip(test):
@functools.wraps(test)
def wrap():
raise nose.exc.SkipTest(reason)
raise pytest.SkipTest(reason)
return wrap
return _skip

Expand Down
4 changes: 2 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ envlist = py26,py27,py34,py35
[testenv]
deps =
flake8
nose
pytest
commands =
flake8 zerorpc bin
nosetests -v
pytest -v
passenv = ZPC_TEST_TIME_FACTOR

[flake8]
Expand Down