Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/crystalvale mining #38

Merged
merged 3 commits into from
Aug 13, 2022
Merged

Conversation

Athiriyya
Copy link
Contributor

Mining quests opened up on Crystalvale on 28 July 2022. I added the contract addresses to dfktools.quests.professions.mining and added dfktools.dex.crystal using the same pattern as the existing dfktools.dex.jewel. Otherwise, it was difficult to get the current locked Crystal value from DFK Chain

@@ -1,2 +1,5 @@
SERENDALE_GOLD_QUEST_CONTRACT_ADDRESS = '0x569E6a4c2e3aF31B337Be00657B4C040C828Dd73'
SERENDALE_JEWEL_QUEST_CONTRACT_ADDRESS = '0x6FF019415Ee105aCF2Ac52483A33F5B43eaDB8d0'

CRYSTALVALE_GOLD_QUEST_CONTRACT_ADDRESS = '0x75912145f5cFEfb980616FA47B2f103210FaAb94'
CRYSTALVALE_JEWEL_QUEST_CONTRACT_ADDRESS = '0x98b3C85ac3cC3EF36Ff25A9229857AbACE3e7410'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to change it to CRYSTALVALE_CRYSTAL_QUEST_CONTRACT_ADDRESS

Copy link
Contributor Author

@Athiriyya Athiriyya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True! Will do.

@0xPotatoofdoom 0xPotatoofdoom mentioned this pull request Aug 4, 2022
@mateiQA
Copy link

mateiQA commented Aug 5, 2022

Hello @Athiriyya , does the quest core v2 class need to be changed as well?

@0rtis 0rtis merged commit 434e80d into 0rtis:master Aug 13, 2022
@Athiriyya Athiriyya deleted the feature/crystalvale_mining branch August 24, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants