Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race in IRP_MJ_DEVICE_CONTROL #2

Closed
0vercl0k opened this issue Feb 14, 2021 · 0 comments
Closed

Fix race in IRP_MJ_DEVICE_CONTROL #2

0vercl0k opened this issue Feb 14, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@0vercl0k
Copy link
Owner

The sic driver has been basically designed to handle one client at a time; the accesses to the global state are not synchronized and as a result two thread could execute the IRP_MJ_DEVICE_CONTROL callback which would probably lead to memory corruptions of some sort.
@0vercl0k 0vercl0k added the bug Something isn't working label Feb 14, 2021
@0vercl0k 0vercl0k mentioned this issue Feb 14, 2021
Merged
0vercl0k added a commit that referenced this issue Feb 14, 2021
@0vercl0k
Fix race in IRP_MJ_DEVICE_CONTROL. (#3)
703effa 
This PR fixes the race described in #2: basically if more than one thread executes the IRP_MJ_DEVICE_CONTROL callback there are a lot of avenues that lead to memory corruption and more.
@0vercl0k 0vercl0k mentioned this issue Feb 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0vercl0k