Stores bochscpu breakpoints in a dictionary. #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how
bochscpu
stores breakpoints to match how other backends do it. It's also bad for performance to iterate over all the breakpoints every time - I think the thought initially was to support multiple breakpoints on the same instruction but I ended up never really using this / implementing this in other backends.On top of that a few other fixes:
cr2
/cr3
in get / set register for the backends.