Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in client metrics #56

Merged
merged 2 commits into from
Dec 12, 2021
Merged

Fix bug in client metrics #56

merged 2 commits into from
Dec 12, 2021

Conversation

0vercl0k
Copy link
Owner

This PR fixes #51 - the issue that happend is the below:

  1. A testcase that generates new coverage but times out
  2. The code grabbed the last new coverage, and added the amount of new coverage to the coverage counter
  3. As the testcase timed-out, this coverage is asked to be revoked

Now let's say the same testcase runs again, retriggers this new coverage but times out; the amount of 'new' coverage gets added again even though it'll get reverted. This happening a large number of times lead to the coverage count being completely inacurrate on the client side.

@0vercl0k 0vercl0k merged commit f0122c4 into main Dec 12, 2021
@0vercl0k 0vercl0k deleted the fbl_revoke branch December 12, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bug w/ revoked coverage & stats
1 participant