Ignore BX_INSERTED_OPCODE in BeforeExecutionHook #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue that happened in #45 - basically bx inserts a 'special' instruction (w/o changing its address) which gets treated like a normal instruction and so the
before_execution
hook gets invoked on it as well but right after, anotherbefore_execution
gets dispatched on the 'real' instruction. This triggered RIP traces to generate traces that looked like:Instead of:
This behavior also meant that it triggered the code that generates the Tenet deltas to generate an empty line which the Tenet plugin doesn't like :).
On top of the above the PR does a few other things:
ShowRegisters
toPrintRegisters
, updated thebx
dependencies to the 2.7 version, CI uses clang13, addedBackend::Rsi
/Backend::Rdi
, remove thevirtual
keyword from the hook functions in the bxcpu backend.