fix regular expressions to allow whitespace before template tag #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry to be annoying, but thought I'd give this a quick bump. Thanks for the extension. Looking forward to this tweak making my life even better. |
|
@shannonmoeller |
|
@0x00000001A I'm so sorry to hear that. I hope things get better for you soon. Thank you very much for your time and merging this change. |
|
Thank you again very much, but it looks like maybe the wrong version number was used? |
|
Thanks for the version bump! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every regular expression that matches the uncommented version of template tags other than the one for
sqlhas a bug: any leading whitespace breaks syntax highlighting. This PR adds support for optional leading whitespace which fixes the issue.Before:
After:
