Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with current 0xSCA RFC #63

Open
Jarvix opened this issue Apr 21, 2012 · 4 comments
Open

Issues with current 0xSCA RFC #63

Jarvix opened this issue Apr 21, 2012 · 4 comments

Comments

@Jarvix
Copy link
Contributor

Jarvix commented Apr 21, 2012

The current 0xSCA has some problems.

Firstly it has grammar mistakes and typos. If those can be pointed at, I will fix them.

Second, the current words on labels contradict in the Labels section and the section at the end of the file.

And local labels use a dot in front but that is not looking clear. Readability is bad. So I think about using an underscore instead

.ifdef DEBUG
label:
.local:
.word 5
.end

.ifdef DEBUG
label:
_local:
.word 5
.end
@kksym
Copy link
Contributor

kksym commented Apr 22, 2012

The underscore prefix does increase readability very well, I must say.

@Jarvix
Copy link
Contributor Author

Jarvix commented Apr 23, 2012

It is going to be _. i cant get the dot implemented nicely in my own assembler :)

@enkore
Copy link
Contributor

enkore commented Apr 23, 2012

told you so :D

@ghost
Copy link

ghost commented Jul 23, 2012

I suggest using :blah labels instead of blah: labels, as that is how they are in the specification. The _ prefix for local labels is nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants