Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist application settings #357

Closed
onguarde opened this issue Aug 20, 2022 · 1 comment · Fixed by #374
Closed

Persist application settings #357

onguarde opened this issue Aug 20, 2022 · 1 comment · Fixed by #374
Labels
bug Something isn't working
Milestone

Comments

@onguarde
Copy link

onguarde commented Aug 20, 2022

The settings don't seem to be saved when the application is closed. This is dangerous because I re-opened the application thinking the checkbox above WAS enabled. I will lose the ability to restore, if I hadn't checked that box.

image

According to #44, this should already be implemented. Perhaps it's a regression?

Btw, the checkbox should be set to ON by default, any reason why it's not?

I'm using the openGL latest 0.51 version.

@onguarde onguarde added the bug Something isn't working label Aug 20, 2022
@0x192 0x192 added this to the 0.6 milestone Aug 28, 2022
@0x192
Copy link
Owner

0x192 commented Aug 28, 2022

The config file currently only keeps the Theme value. This is not ideal but I didn't want to add the others settings before I implement unique settings for each phone.

I would point out that the category name of those settings explicitly says that those are not persistent (look at your screenshot 😉)

For example, if you tick clear and disable... for your Android 9 phone and then plug another phone with Android 4.4, there will be a problem because you can't disable an app on Android 4.4. You have to use adb pm block / unblock which is the equivalent of an adb pm uninstall.

I'll prefer each phone to have its own settings.

Anyway, that's a feature for the next release!


This is dangerous because I re-opened the application thinking the checkbox above WAS enabled. I will lose the ability to restore

Uninstalling an app will not prevent you to restore it. The defaults settings are pretty smart. You can always restore an application. Take a look at the adb commands used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants