Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1] mmGameMulti::StartXYZ() #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KcRobin9
Copy link
Collaborator

@KcRobin9 KcRobin9 commented Dec 22, 2023

In an attempt to fix the incorrect starting positions in multiplayer (more specifically, the 2nd till 8th player are stacked on top of each other), first re-implement the position spacing function. We tested this function with a different offset for 2 players, and this worked. However, it seems like this function isn't the root cause of the problem.

Spawn_Problem_1

@0x1F9F1
Copy link
Owner

0x1F9F1 commented Feb 20, 2024

When the offset is wrong, have you tried logging the index being passed in? Is it correct for all players/on all clients?

@KcRobin9
Copy link
Collaborator Author

I prepared a custom Open1560 version that logs the index, once we've played an online game with 4-8 players and gathered all logs I will upload it here

@0x1F9F1
Copy link
Owner

0x1F9F1 commented Mar 19, 2024

Were you able to figure out if the player index is being passed in correctly?

@KcRobin9
Copy link
Collaborator Author

Not yet (haven't had a full lobby with the custom build yet). Update will follow

@KcRobin9
Copy link
Collaborator Author

We have tested the case, and it seems that indeed the player index is passed incorrectly (only index 0 and 1 are passed).

See the picture below for more details.

I have also attached the logs of 5 players of 2 separate attempts for completeness, but the part in the log about the indices are all the same.

LOG_PICTURE

Index_Logs.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants