Implement Multiple Polygon Functions #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aim is to understand how the collision table is generated, such that this knowledge can be applied when creating the `_HITID.BND` from scratch.
0x1F9F1
reviewed
Mar 19, 2024
| @@ -248,7 +248,7 @@ class mmBoundTemplate | |||
| // ?WinID@mmBoundTemplate@@2HA | mmdyna:bndtmpl2 | |||
| ARTS_IMPORT static i32 WinID; | |||
|
|
|||
| private: | |||
| public: | |||
There was a problem hiding this comment.
Does this need to be made public?
There was a problem hiding this comment.
Yes.
It's required for mmBoundTemplate::VertPtr and the ->X/Y/Z Dims
code/midtown/mmdyna/poly.cpp
Outdated
| f32 mmPolygon::CheckCellXSide(f32 x_plane, f32 z_min, f32 z_max) | ||
| { | ||
| f32 max_y = -999999.0f; | ||
| i32 vert_count = (Flags & 4) != 0 ? 4 : 3; |
There was a problem hiding this comment.
Could you replace the manual flag checks with functons? Like IsQuad() and GetNumVerts()
code/midtown/mmdyna/poly.cpp
Outdated
Comment on lines
44
to
47
| if (y_int > max_y) | ||
| { | ||
| max_y = y_int; | ||
| } |
code/midtown/mmdyna/poly.cpp
Outdated
| f32 max_y = -999999.0f; | ||
| i32 vert_count = (Flags & 4) ? 4 : 3; | ||
| f32 adjusted_sign = (PlaneN.y <= 0.0f) ? 1.0f : -1.0f; | ||
| f32 x_plane[4], z_plane[4], const_plane[4], length, inverse_length; |
There was a problem hiding this comment.
Try and avoid forward declaring variables when not necssary, i.e length, inverse_length
code/midtown/mmdyna/poly.cpp
Outdated
|
|
||
| for (i32 i = 0; i < vert_count; ++i) | ||
| { | ||
| const Vector3& cur_vert = mmBoundTemplate::VertPtr[VertIndices[i % vert_count]]; |
code/midtown/mmdyna/poly.cpp
Outdated
| return max_y; | ||
| } | ||
|
|
||
| f32 mmPolygon::CheckCorner(f32 x, f32 z, f32* x_plane, f32* z_plane, f32* const_plane) |
There was a problem hiding this comment.
I think maybe plane_x, plane_z, and plane_d may be better names for these
code/midtown/mmdyna/poly.cpp
Outdated
Comment on lines
134
to
146
| f32 corner_height; | ||
|
|
||
| corner_height = CheckCorner(x1, z1, x_plane, z_plane, const_plane); | ||
| max_y = std::max(max_y, corner_height); | ||
|
|
||
| corner_height = CheckCorner(x1, z2, x_plane, z_plane, const_plane); | ||
| max_y = std::max(max_y, corner_height); | ||
|
|
||
| corner_height = CheckCorner(x2, z1, x_plane, z_plane, const_plane); | ||
| max_y = std::max(max_y, corner_height); | ||
|
|
||
| corner_height = CheckCorner(x2, z2, x_plane, z_plane, const_plane); | ||
| max_y = std::max(max_y, corner_height); |
There was a problem hiding this comment.
You can just inline these into the param for max, not much point assigning them to a variable
Hopefully all points are addressed adequately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim is to understand how the collision table is generated, such that this knowledge can be applied when creating the
_HITID.BNDfrom scratch.