Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminating a loading animation with .error() should look the same as .success() but with a red ❌ #57

Open
DanMacDonald opened this issue Oct 16, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@DanMacDonald
Copy link

Describe the bug
Ending the loading animation with .error(...) or .done().error(...) leaves the loading text in the terminal and doesn't replace it like the .success(...) message does.

To Reproduce
Steps to reproduce the behavior:

  1. start a loading animation with logger.loading(format!("{test_name}..."));
  2. end the loading animation with logger.error(format!("{test_name} - {duration:?}"));
  3. Note that you see something like
    image

Expected behavior
I would expect it to format like ending it with success(...)
image
(this is an different test that passed)

*Desktop (please complete the following information):

  • OS: MacOS 12.0.1
  • Browser: Terminal in VSCode

Additional context
running cargo run --release
the test that's failing is a long running test, takes about 30s before it fails.

@DanMacDonald DanMacDonald added the bug Something isn't working label Oct 16, 2023
@0x20F
Copy link
Owner

0x20F commented Oct 17, 2023

Hi!
Nice catch! I'll take a look at fixing it as soon as I can!

@ghost
Copy link

ghost commented Nov 30, 2023

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants