fix file permissions when creating cache files. fixes cakephp#2080.

0x20h · Oct 11, 2011 · 0938d01 · 0938d01
1 parent e894ab2
commit 0938d01
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/cake/libs/cache/file.php b/cake/libs/cache/file.php
@@ -141,10 +141,11 @@ function write($key, &$data, $duration) {
 
 		$expires = time() + $duration;
 		$contents = $expires . $lineBreak . $data . $lineBreak;
+		$old = umask(0);
+		$handle = fopen($this->__File->path, 'a');
+		umask($old);
 
-		if (!$handle = fopen($this->__File->path, 'a')) {
-		    return false;
-		}
+		if (!$handle) return false;
 
 		if ($this->settings['lock']) {
 			flock($handle, LOCK_EX);