Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync template #1

Merged
merged 20 commits into from Feb 18, 2024
Merged

Sync template #1

merged 20 commits into from Feb 18, 2024

Conversation

Keyrxng
Copy link

@Keyrxng Keyrxng commented Feb 17, 2024

Resolves ubiquity#166

@Keyrxng Keyrxng requested a review from 0x4007 as a code owner February 17, 2024 18:34
@Keyrxng
Copy link
Author

Keyrxng commented Feb 17, 2024

everything resolved but haven't fully tested all of the functions

@0x4007
Copy link
Owner

0x4007 commented Feb 18, 2024

Thank for this! But you should have used @ubiquity/pay.ubq.fi as the merge target.

Copy link
Owner

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great but I saw some words that I don't expect to have passed spell check. Did you make sure to run cspell as part of the yarn format and commit lint?

static/scripts/rewards/web3/wallet.ts Outdated Show resolved Hide resolved
static/scripts/rewards/web3/wallet.ts Outdated Show resolved Hide resolved
static/scripts/rewards/abis/nftRewardAbi.ts Show resolved Hide resolved
static/scripts/audit-report/types/audit.d.ts Outdated Show resolved Hide resolved
.eslintrc Outdated Show resolved Hide resolved
@0x4007 0x4007 merged commit 267491a into 0x4007:sync-template Feb 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants