Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken favicon due to interaction with Agenda pluging #13

Open
andremann opened this issue Oct 18, 2022 · 1 comment
Open

Broken favicon due to interaction with Agenda pluging #13

andremann opened this issue Oct 18, 2022 · 1 comment

Comments

@andremann
Copy link

The Agenda plugin (https://github.com/haydenull/logseq-plugin-agenda) offers a Pomodoro timer that renders a badge at the end of the tracking.

Since the block looks like this [🍅 1min](#agenda-pomo://?t=p-1666074628585-4), your plugin tries to render a favicon for the URI and fails fetching it.
195817449-e65f410e-da5a-4e56-9c5b-ce6431c813de

@andremann
Copy link
Author

andremann commented Oct 18, 2022

Maybe the problem is in the faviconObserver assuming it is right to fetch a favicon for every URL in (...), which is not in the case above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant