Added Arabic translation [ar-YE] #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2021
0x7c13
requested changes
Mar 20, 2021
src/Notepads/Notepads.csproj
Outdated
| @@ -449,6 +449,15 @@ | |||
| <ItemGroup> | |||
| <None Include="Package.targets" /> | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
There was a problem hiding this comment.
You can remove these lines since it will be covered by PRIResource Include="Strings***.resw"
There was a problem hiding this comment.
Only L449 to L451?
There was a problem hiding this comment.
@HasanAlyazidi only remove the lines you have added L452 to L460.
There was a problem hiding this comment.
@soumyamahunt @Jasonstein done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Translation
Screenshots
Main:
Settings:
Other information
There is a bug that appear only for RTL languages and I will create an issue for that.