🔧 adopt the naming convention for tests #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adopting the convention, we blacklist non-relevant tests from the gas report. That produces a more realistic and accurate report. In addition, I decide to use the suffix `_ReportSkip` to blacklist tests that do not expect to revert but are not relevant for the gas report because they test a failure case. Helpful and relevant in a case of a library that returns a boolean that is supposed to return true when correctly used.
Now that we automatically filter non-relevant tests, numbers are much more realistic.
qd-qd
force-pushed
the
improve-gas-report
branch
from
5f7014f
to
7b045f3
Compare
Changes to gas cost
🧾 Summary (20% most significant diffs)
Full diff report 👇
|
LCOV of commit
|
|
Gas consumption didn't change, we only blacklisted non-relevant tests that reverted. As those tests consumed less gas than the successful ones (as the execution is stopped before the end of the computation), the average consumption seems to raise. The logic didn't change, but the previous gas snapshots were misleading. This PR fixes that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adopting the convention, we blacklist non-relevant tests from the gas report. That produces a more realistic and accurate report. In addition, I decide to use the suffix
_ReportSkipto blacklist tests that do not expect to revert but are not relevant to the gas report because they test a failure case. Helpful and relevant in the case of a library that returns a boolean that is supposed to return true when correctly used.In this PR, gas reports are updated after we filtered the non-relevant tests.