chore(test): use testcontainers modules #1164
Conversation
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
0xERR0R
force-pushed
the
testcontainers-module
branch
2 times, most recently
from
12e221b
to
618cc87
Compare
0xERR0R
force-pushed
the
testcontainers-module
branch
from
618cc87
to
2585fd1
Compare
| testcontainers.WithWaitStrategy( | ||
| wait.ForLog("database system is ready to accept connections"). | ||
| WithOccurrence(waitLogOccurrence). | ||
| WithStartupTimeout(startupTimeout)), |
There was a problem hiding this comment.
I was wondering why this is the only one using WithWaitStrategy and from looking at testcontainers code, the others have one built-in.
Might be worth making an issue/PR to add a built-in one for postgres too since the others also use log matching, so there's no reason this couldn't be built-in.
There was a problem hiding this comment.
Yes, I have also noticed that. In official example for postgres (https://golang.testcontainers.org/modules/postgres/) is a wait strategy defined. In redis and mariaDB not.
There was a problem hiding this comment.
Found this comment: testcontainers/testcontainers-go#1619 (comment)
There was a problem hiding this comment.
Nice find, glad they're thinking of it.
| ExposedPorts: []string{"6379/tcp"}, | ||
| NetworkAliases: map[string][]string{NetworkName: {"redis"}}, | ||
| WaitingFor: wait.ForExposedPort(), | ||
| func WithNetwork(network string) testcontainers.CustomizeRequestOption { |
There was a problem hiding this comment.
FYI we have just added a WithNetwork option here: testcontainers/testcontainers-go#1894
There was a problem hiding this comment.
Thanks, this is very cool, I'll change our implementation 🤝
testcontainers provides predefined containers for major databases. This PR replaces mariadb, postgeres and redis with testcontainers modules.