Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ANSI color codes being printed on Windows #1225

Merged
merged 3 commits into from Nov 7, 2023

Conversation

kwitsch
Copy link
Collaborator

@kwitsch kwitsch commented Nov 7, 2023

Set logger output to colorable.NewColorableStdout for FormatTypeText to fix missing colors in Windows.

Closes: #1204

@kwitsch kwitsch added the 🐞 bug Something isn't working label Nov 7, 2023
@kwitsch kwitsch added this to the v0.23 milestone Nov 7, 2023
@kwitsch kwitsch requested a review from 0xERR0R November 7, 2023 19:07
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

@ThinkChaos ThinkChaos changed the title Issues/1204 fix: ANSI color codes being printed on Windows Nov 7, 2023
@kwitsch kwitsch merged commit d87e6b4 into 0xERR0R:main Nov 7, 2023
3 checks passed
@kwitsch kwitsch deleted the issues/1204 branch November 7, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unresolved color codes in windows console - binary 0.22
2 participants