Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring server.go #1277

Merged
merged 8 commits into from Nov 28, 2023
Merged

Refactoring server.go #1277

merged 8 commits into from Nov 28, 2023

Conversation

kwitsch
Copy link
Collaborator

@kwitsch kwitsch commented Nov 27, 2023

Changes:

  • server.go: removed context.Background from OnRequest in favor of ctx
  • server.go: Stop uses ShutdownContext
  • helper.go: DoGetRequest uses NewRequestWithContext
  • fixed some flakyness in tests

Part of #1264

@kwitsch kwitsch added the 🧰 technical debts Technical debts, refactoring label Nov 27, 2023
@kwitsch kwitsch added this to the v0.23 milestone Nov 27, 2023
@kwitsch kwitsch mentioned this pull request Nov 27, 2023
Open
11 tasks
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (15bd383) 93.87% compared to head (c9edb93) 93.75%.
Report is 1 commits behind head on main.

Files Patch % Lines
redis/redis.go 66.66% 15 Missing and 5 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1277      +/-   ##
==========================================
- Coverage   93.87%   93.75%   -0.13%     
==========================================
  Files          75       77       +2     
  Lines        6023     6083      +60     
==========================================
+ Hits         5654     5703      +49     
- Misses        284      292       +8     
- Partials       85       88       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ThinkChaos
ThinkChaos approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@ThinkChaos ThinkChaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kwitsch kwitsch merged commit 976d619 into 0xERR0R:main Nov 28, 2023
10 of 11 checks passed
@kwitsch kwitsch deleted the refactoring/server branch November 28, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThinkChaos ThinkChaos ThinkChaos approved these changes

Assignees
No one assigned
Labels
🧰 technical debts Technical debts, refactoring
Projects
None yet
Milestone
v0.23
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwitsch @ThinkChaos