Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring/config struct names #1315

Merged
merged 16 commits into from Dec 20, 2023
Merged

Refactoring/config struct names #1315

merged 16 commits into from Dec 20, 2023

Conversation

kwitsch
Copy link
Collaborator

@kwitsch kwitsch commented Dec 20, 2023

Changes:

@kwitsch kwitsch added the 🧰 technical debts Technical debts, refactoring label Dec 20, 2023
@kwitsch kwitsch enabled auto-merge (squash) December 20, 2023 18:01
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023 •
edited

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dece894) 93.83% compared to head (0c925b6) 93.83%.

❗ Current head 0c925b6 differs from pull request most recent head 546b136. Consider uploading reports for the commit 546b136 to get more accurate results

Files Patch % Lines
config/config.go 92.30% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1315   +/-   ##
=======================================
  Coverage   93.83%   93.83%           
=======================================
  Files          77       77           
  Lines        6200     6200           
=======================================
  Hits         5818     5818           
  Misses        293      293           
  Partials       89       89

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ThinkChaos
ThinkChaos reviewed Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@ThinkChaos ThinkChaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a couple leftovers hiding in comments

config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
kwitsch and others added 3 commits December 20, 2023 21:37
@kwitsch @ThinkChaos
Update config/config.go
26bce0e 
Co-authored-by: ThinkChaos <ThinkChaos@users.noreply.github.com>
@kwitsch @ThinkChaos
Update config/config.go
546b136 
Co-authored-by: ThinkChaos <ThinkChaos@users.noreply.github.com>
@kwitsch @ThinkChaos
Update config/config.go
a37ce9f 
Co-authored-by: ThinkChaos <ThinkChaos@users.noreply.github.com>
@kwitsch kwitsch merged commit 03131c4 into 0xERR0R:main Dec 20, 2023
@kwitsch kwitsch deleted the refactoring/config-names branch December 20, 2023 20:38
@kwitsch kwitsch mentioned this pull request Dec 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThinkChaos ThinkChaos ThinkChaos approved these changes

Assignees
No one assigned
Labels
🧰 technical debts Technical debts, refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwitsch @ThinkChaos