Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no initial cache refresh with "fast" start strategy #804

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

0xERR0R
Copy link
Owner

@0xERR0R 0xERR0R commented Dec 16, 2022

When startStrategy is "fast", no initial cache refresh was performed

closes #799

@0xERR0R 0xERR0R added the 🐞 bug Something isn't working label Dec 16, 2022
@0xERR0R 0xERR0R added this to the 0.21 milestone Dec 16, 2022
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 93.39% // Head: 93.34% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (44213ed) compared to base (8b137bb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #804      +/-   ##
===============================================
- Coverage        93.39%   93.34%   -0.06%     
===============================================
  Files               42       42              
  Lines             4848     4851       +3     
===============================================
  Hits              4528     4528              
- Misses             252      255       +3     
  Partials            68       68              
Impacted Files Coverage Δ
lists/list_cache.go 98.14% <100.00%> (+0.02%) ⬆️
resolver/blocking_resolver.go 98.14% <0.00%> (-0.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@kwitsch kwitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kwitsch kwitsch merged commit 3c40ce5 into development Dec 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-list-refresh branch December 17, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

startStrategy: fast inline regex not working?
3 participants