Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add upstream string to resolve error #902

Merged

Conversation

ThinkChaos
Copy link
Collaborator

Fixes #872

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 93.15% // Head: 93.07% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (1f25e45) compared to base (d64b399).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #902      +/-   ##
===============================================
- Coverage        93.15%   93.07%   -0.09%     
===============================================
  Files               42       42              
  Lines             4950     4950              
===============================================
- Hits              4611     4607       -4     
- Misses             268      271       +3     
- Partials            71       72       +1     
Impacted Files Coverage Δ
resolver/upstream_resolver.go 89.01% <100.00%> (ø)
resolver/query_logging_resolver.go 95.62% <0.00%> (-2.92%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@0xERR0R 0xERR0R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@0xERR0R 0xERR0R added the 🔨 enhancement New feature or request label Feb 28, 2023
@0xERR0R 0xERR0R added this to the 0.21 milestone Feb 28, 2023
@0xERR0R 0xERR0R merged commit de9acd3 into 0xERR0R:development Feb 28, 2023
@ThinkChaos ThinkChaos deleted the feat/upstream-error-endpoint-string branch February 28, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Using actual endpoint string in the config to display warning/error, instead of all IP address
2 participants