-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]: support governance #49
Conversation
contracts/SafeMath.sol
Outdated
@@ -0,0 +1,206 @@ | |||
pragma solidity ^0.8.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import this lib from openzepplin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Already done.
emit CancelTransaction(txHash, target, value, signature, data, eta); | ||
} | ||
|
||
function executeTransaction( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reuse those functions from transactionModule
test/governance_token.test.ts
Outdated
|
||
const provider = waffle.provider | ||
|
||
function expandTo18Decimals(n: number): BigNumber { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use ethers.utils.parseEther
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Already done.
test/governance_token.test.ts
Outdated
let other0 | ||
let other1 | ||
before(async () => { | ||
;[wallet, other0, other1] = await hre.ethers.getSigners() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the leading semicolon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Already done.
No description provided.