Skip to content
This repository has been archived by the owner on Nov 4, 2020. It is now read-only.

feat: show submitted votes on a voting screen #84

Merged
merged 11 commits into from
Sep 6, 2019
Merged

Conversation

troggy
Copy link
Collaborator

@troggy troggy commented Sep 6, 2019

Resolves #82, #43, #44, #83, #2, #90, #68

In progress: #26

Features:

  • after the vote, closing the voting control and go to proposal list
  • disables "Yes" or "No" button if the vote is already casted
  • allows to add/remove votes from existing vote (only "Yes" path tested so far)
  • disallow to drag slider to 0 for existing votes

@troggy troggy changed the title feat: show submitted votes on a voting screen [WIP] feat: show submitted votes on a voting screen Sep 6, 2019
@troggy troggy changed the title [WIP] feat: show submitted votes on a voting screen feat: show submitted votes on a voting screen Sep 6, 2019
Copy link

@johannbarbie johannbarbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

export const Header = props => {
const { credits, maxCredits = 25, openMenu } = props;
let availableCredits = '--';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just copied existing behavior

console.log({ credits, castedCredits });

const totalCredits = castedCredits.add(credits || new BN(0)).div(factor18);
// no sqrt in BN.js 🤷‍

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

you should see your existing vote on a voting screen
2 participants