This repository has been archived by the owner on Nov 4, 2020. It is now read-only.
forked from social-dist0rtion-protocol/planet-a
-
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: show submitted votes on a voting screen #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troggy
changed the title
feat: show submitted votes on a voting screen
[WIP] feat: show submitted votes on a voting screen
Sep 6, 2019
troggy
force-pushed
the
fix/show-votes
branch
from
September 6, 2019 13:48
5f0b55a
to
3d70379
Compare
troggy
changed the title
[WIP] feat: show submitted votes on a voting screen
feat: show submitted votes on a voting screen
Sep 6, 2019
troggy
force-pushed
the
fix/show-votes
branch
from
September 6, 2019 17:54
a02ee26
to
b9a8bb5
Compare
This was referenced Sep 6, 2019
johannbarbie
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
export const Header = props => { | ||
const { credits, maxCredits = 25, openMenu } = props; | ||
let availableCredits = '--'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just copied existing behavior
console.log({ credits, castedCredits }); | ||
|
||
const totalCredits = castedCredits.add(credits || new BN(0)).div(factor18); | ||
// no sqrt in BN.js 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed
This was referenced Sep 6, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #82, #43, #44, #83, #2, #90, #68
In progress: #26
Features: