Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recursive imports, add @zkemail npm imports, fix github link imports #15

Merged
merged 8 commits into from
Nov 4, 2023

Conversation

Divide-By-0
Copy link
Contributor

@Divide-By-0 Divide-By-0 commented Oct 29, 2023

Ready to merge! Preview available on https://zkemailrepl.onrender.com.

Changes I made:

  • previously only 'blob' in github links was handled right. now 'tree' in github links is handled correctly also.
  • files that import other files that are all circomlib or in @zk-email packages, are imported correctly
  • All external imports are at /external so relative to root. resolves the double import problem i.e. x imports y and z imports w imports y would otherwise cause a double definition of y otherwise. works for imports on different depths.
  • circomlib also imported from root regardless of level of import it appears in, making complex import hierarchies still work

Future to-dos:

  • Import any npm package correctly by sourcing what the git url is automatically from npmjs, instead of one-off packages to url mapping being in this libraries.ts file.

@antimatter15 antimatter15 merged commit 331b2f8 into 0xPARC:main Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants