Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #316

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update README.md #316

wants to merge 4 commits into from

Conversation

0xkryptstein
Copy link

deleted $ symbol so command lines can be copied and pasted into terminals

Description

Jira / Linear Tickets

Testing

  • Test A
  • Test B

deleted $ symbol so command lines can be copied and pasted into terminals
@criadoperez
Copy link
Contributor

I wouldn't remove it. The $ is there so you can easily see the difference between the command itself and the output of the command.

Add # Output example
Updated the output example
@0xkryptstein
Copy link
Author

Updated the file with a clear output example

Copy link
Member

@leovct leovct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update @0xkryptstein! I think you can drop most of the output examples.

Comment on lines +91 to 96
Output example

```bash
INFO [07-10|10:43:12.499] Starting Geth in ephemeral dev mode...
...
```
Copy link
Member

@leovct leovct Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can just drop the output example.

make geth-loadtest
```

Output example
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Comment on lines +139 to +141
Output example

```bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants