Final touches to Sonarcloud (#2030)

* Remove sonar host env var
* Fix coverage

.github/workflows/ci.yml

@@ -15,4 +15,3 @@ jobs:
     needs: build
     secrets:
       SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
-      SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}

.github/workflows/nightly.yml

@@ -22,7 +22,6 @@ jobs:
     needs: build
     secrets:
       SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
-      SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
 
   e2e:
     name: PolyBFT E2E Tests

.github/workflows/test.yml

@@ -6,8 +6,6 @@ on:  # yamllint disable-line rule:truthy
     secrets:
       SONAR_TOKEN:
         required: false
-      SONAR_HOST_URL:
-        required: false
     outputs:
       workflow_output:
         description: "Unit tests output"
@@ -29,6 +27,7 @@ jobs:
         uses: actions/checkout@v3
         with:
           submodules: recursive
+          fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
 
       - name: Install Dependencies
         run: ./setup-ci.sh
@@ -41,15 +40,6 @@ jobs:
         id: run_tests_failure
         run: echo "test_output=false" >> $GITHUB_OUTPUT
 
-  sonar-scan:
-    name: SonarQube Scan
-    needs: go_test
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout Branch
-        uses: actions/checkout@v3
-        with:
-          fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
       - name: SonarCloud Scan
         if: ${{ env.HAVE_SONAR_TOKEN == 'true' }}
         uses: SonarSource/sonarcloud-github-action@master

sonar-project.properties

@@ -2,7 +2,7 @@ sonar.projectKey=0xPolygon_polygon-edge
 sonar.organization=0xpolygon
 
 sonar.sources=.
-sonar.exclusions=**/*_test.go,**/vendor/**,**/*.py,**/core-contracts/**,**/tests/**
+sonar.exclusions=**/vendor/**,**/*.py,**/core-contracts/**,**/tests/**
 
 sonar.tests=.
 sonar.test.inclusions=**/*_test.go