Explicitly notify about chain id usage (#1494)

Include comment in flag help and verify it when building genesis for Polybft
0xPolygon · May 11, 2023 · 8ea9136 · 8ea9136
1 parent 405ad1a
commit 8ea9136
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/command/genesis/genesis.go b/command/genesis/genesis.go
@@ -45,7 +45,7 @@ func setFlags(cmd *cobra.Command) {
 		&params.chainID,
 		chainIDFlag,
 		command.DefaultChainID,
-		"the ID of the chain",
+		"the ID of the chain (only used for IBFT consensus)",
 	)
 
 	cmd.Flags().StringVar(

diff --git a/command/genesis/params.go b/command/genesis/params.go
@@ -62,6 +62,7 @@ var (
 	errInvalidTokenParams     = errors.New("native token params were not submitted in proper format " +
 		"(<name:symbol:decimals count:mintable flag>)")
 	errRewardWalletAmountZero = errors.New("reward wallet amount can not be zero or negative")
+	errChainIDPolyBFT         = errors.New("chain id can not be set for polybft consensus")
 )
 
 type genesisParams struct {
@@ -150,6 +151,10 @@ func (p *genesisParams) validateFlags() error {
 		if err := p.validateRewardWallet(); err != nil {
 			return err
 		}
+
+		if p.chainID != command.DefaultChainID {
+			return errChainIDPolyBFT
+		}
 	}
 
 	// Check if the genesis file already exists