Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the limit for TX pool contract creation size #1345

Merged
merged 4 commits into from
Mar 30, 2023
Merged

Fix the limit for TX pool contract creation size #1345

merged 4 commits into from
Mar 30, 2023

Conversation

vcastellm
Copy link
Contributor

Description

The limit should be double the size of contract code size.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Fix the limit for TX pool contract creation size
7cb1375 
The limit should be double the size of contract code size.
@vcastellm vcastellm requested a review from a team March 29, 2023 13:41
@vcastellm vcastellm self-assigned this Mar 29, 2023
@vcastellm vcastellm added bug fix Functionality that fixes a bug hotfix Major bug fix that should be merged ASAP labels Mar 29, 2023
@vcastellm vcastellm marked this pull request as ready for review March 29, 2023 13:41
Victor Castell added 2 commits March 29, 2023 16:08
Stefan-Ethernal
Stefan-Ethernal approved these changes Mar 29, 2023
View reviewed changes
txpool/txpool_test.go Outdated Show resolved Hide resolved
pano-skylakis
pano-skylakis approved these changes Mar 29, 2023
View reviewed changes
Copy link

@pano-skylakis pano-skylakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@vcastellm @Stefan-Ethernal
Update txpool/txpool_test.go
5adec77 
Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
@vcastellm vcastellm merged commit 879cdf5 into develop Mar 30, 2023
@vcastellm vcastellm deleted the EVM-564-fix-contract-deployment-size-limit branch March 30, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pano-skylakis pano-skylakis pano-skylakis approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@stana-miric stana-miric stana-miric approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@vcastellm vcastellm

Labels
bug fix Functionality that fixes a bug hotfix Major bug fix that should be merged ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vcastellm @pano-skylakis @Stefan-Ethernal @stana-miric @goran-ethernal