Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a new version of go ibft #1392

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Introduce a new version of go ibft #1392

merged 4 commits into from
Jun 1, 2023

Conversation

Nemanja0x
Copy link
Collaborator

@Nemanja0x Nemanja0x commented Apr 17, 2023 •
edited

Description

Edge implements voting power interface for go-ibft

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Simple HasQuorum is left on edge side in order to validate block headers. More complex version of HasQuorum has been introduced on go-ibft side.

@Nemanja0x Nemanja0x force-pushed the Reference_vp_go_ibft branch 2 times, most recently from 45b2c43 to d0fe526 Compare April 19, 2023 09:39
@Nemanja0x Nemanja0x self-assigned this Apr 19, 2023
@Nemanja0x Nemanja0x added the feature New update to Polygon Edge label Apr 19, 2023
@Nemanja0x Nemanja0x marked this pull request as ready for review April 19, 2023 10:04
goran-ethernal
goran-ethernal approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@goran-ethernal goran-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from small comments, LGTM

Stefan-Ethernal
Stefan-Ethernal approved these changes Apr 20, 2023
View reviewed changes
go.mod Show resolved Hide resolved
consensus/polybft/validator_set.go Outdated Show resolved Hide resolved
consensus/polybft/validator_set.go Outdated Show resolved Hide resolved
consensus/polybft/consensus_runtime.go Show resolved Hide resolved
vcastellm
vcastellm approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nemanja0x Nemanja0x merged commit dd13966 into develop Jun 1, 2023
8 checks passed
@Nemanja0x Nemanja0x deleted the Reference_vp_go_ibft branch June 1, 2023 06:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@stana-miric stana-miric stana-miric approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@Nemanja0x Nemanja0x

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Nemanja0x @vcastellm @Stefan-Ethernal @stana-miric @goran-ethernal