Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate bridge access list contracts #1456

Merged
merged 18 commits into from
May 4, 2023
Merged

Integrate bridge access list contracts #1456

merged 18 commits into from
May 4, 2023

Conversation

vcastellm
Copy link
Contributor

@vcastellm vcastellm commented Apr 30, 2023 •
edited
Loading

Description

This PR integrates the new AccessList enabled versions of the ERC20/721/1155 Predicates for the bridge In the same address as the original ones.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@vcastellm vcastellm changed the title Evm 624 integrate access list contracts Integrate access list contracts Apr 30, 2023
@vcastellm vcastellm changed the title Integrate access list contracts Integrate bridge access list contracts Apr 30, 2023
@vcastellm vcastellm self-assigned this May 3, 2023
@vcastellm vcastellm added the feature New update to Polygon Edge label May 3, 2023
@vcastellm vcastellm requested a review from a team May 3, 2023 08:57
@vcastellm vcastellm marked this pull request as ready for review May 3, 2023 08:57
Stefan-Ethernal
Stefan-Ethernal reviewed May 4, 2023
View reviewed changes
e2e-polybft/e2e/bridge_test.go Outdated Show resolved Hide resolved
e2e-polybft/e2e/bridge_test.go Outdated Show resolved Hide resolved
e2e-polybft/e2e/bridge_test.go Show resolved Hide resolved
e2e-polybft/e2e/bridge_test.go Outdated Show resolved Hide resolved
e2e-polybft/e2e/bridge_test.go Show resolved Hide resolved
e2e-polybft/e2e/bridge_test.go Outdated Show resolved Hide resolved
e2e-polybft/e2e/bridge_test.go Outdated Show resolved Hide resolved
consensus/polybft/polybft_config.go Outdated Show resolved Hide resolved
consensus/polybft/polybft_config.go Outdated Show resolved Hide resolved
consensus/polybft/polybft_config.go Show resolved Hide resolved
Stefan-Ethernal and others added 5 commits May 4, 2023 10:13
@Stefan-Ethernal
Build fixes
7617378
@vcastellm @Stefan-Ethernal
Apply suggestions from code review
8a879eb 
Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
@vcastellm
Update SCs
9d10dc2
@vcastellm
Apply feedback
6b0161c
@vcastellm
Fmt
e81bd45
@vcastellm vcastellm merged commit 5e3d3ff into develop May 4, 2023
@vcastellm vcastellm deleted the EVM-624-integrate-access-list-contracts branch May 4, 2023 15:06
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@vcastellm vcastellm

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vcastellm @Stefan-Ethernal @goran-ethernal