Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce BASEFEE opcode #1469

Merged
merged 11 commits into from
May 24, 2023
Merged

Introduce BASEFEE opcode #1469

merged 11 commits into from
May 24, 2023

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented May 3, 2023

Description

Introduce BASEFEE opcode

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@begmaroman begmaroman self-assigned this May 3, 2023
@begmaroman begmaroman added the feature New update to Polygon Edge label May 3, 2023
Copy link
Contributor

@igorcrevar igorcrevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor objection but otherwise looks good

Edit: I have already approved but then I realized that tests are failing. I think you need to enable opcode only if London fork is enabled:

func opBaseFee(c *state) {
    if !c.config.London {
        c.exit(errOpCodeNotFound)

        return
    }

    baseFee := big.NewInt(0).Set(c.host.GetTxContext().BaseFee)
    c.push1().SetUint64(baseFee.Uint64())
}

@begmaroman begmaroman requested a review from ferranbt May 22, 2023 15:37
@begmaroman begmaroman merged commit 1f16cbc into develop May 24, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2023
@begmaroman begmaroman deleted the feature/EVM-628 branch May 24, 2023 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants