Allow min commitment of single state sync event #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
force-pushed
the
EVM-616-fill-commitments-that-have-only-single-state-sync
branch
from
2c57ef0
to
25cd759
Compare
goran-ethernal
force-pushed
the
EVM-616-fill-commitments-that-have-only-single-state-sync
branch
from
4940574
to
b6df9a2
Compare
goran-ethernal
added
feature
goran-ethernal
force-pushed
the
EVM-616-fill-commitments-that-have-only-single-state-sync
branch
from
877619c
to
1ed3448
Compare
goran-ethernal
force-pushed
the
EVM-616-fill-commitments-that-have-only-single-state-sync
branch
from
406945c
to
0a647f9
Compare
Stefan-Ethernal
commented
May 23, 2023
Nemanja0x
approved these changes
May 23, 2023
igorcrevar
approved these changes
May 23, 2023
goran-ethernal
force-pushed
the
EVM-616-fill-commitments-that-have-only-single-state-sync
branch
from
0a647f9
to
1046cf4
Compare
goran-ethernal
deleted the
EVM-616-fill-commitments-that-have-only-single-state-sync
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Through this PR we are supporting a single state sync event per commitment. There is a real case where one deposit can be put on hold until another one happens, because, before this PR, minimum commitment size was 2.
This now helps users to quickly execute their deposit on
L2, since if no other deposit happens in the given sprint, commitment with only that one state sync event will be committed toStateReceivercontract, and user can execute its deposit without the need to wait for another one.Changes include
Checklist
Testing