Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore running edge in local #1502

Merged
merged 4 commits into from
May 15, 2023
Merged

Restore running edge in local #1502

merged 4 commits into from
May 15, 2023

Conversation

vcastellm
Copy link
Contributor

Description

This PR restore the functionality of cluster script for running in local for development and testing

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Running the script

@vcastellm vcastellm self-assigned this May 12, 2023
@vcastellm vcastellm added the bug fix Functionality that fixes a bug label May 12, 2023
@vcastellm vcastellm requested a review from a team May 12, 2023 14:21
@vcastellm vcastellm marked this pull request as ready for review May 12, 2023 14:22
goran-ethernal
goran-ethernal approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@goran-ethernal goran-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stefan-Ethernal
Stefan-Ethernal approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from minor suggestion, LGTM

scripts/cluster Outdated Show resolved Hide resolved
@vcastellm vcastellm merged commit 2dcc318 into develop May 15, 2023
5 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
@vcastellm vcastellm deleted the EVM-645-restore-running-edge-in-local branch May 15, 2023 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@vcastellm vcastellm

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vcastellm @Stefan-Ethernal @goran-ethernal