Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestProperty_DifferentVotingPower by providing randomized stake amounts #1507

Merged
merged 3 commits into from
May 16, 2023

Conversation

Stefan-Ethernal
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal commented May 15, 2023

Description

This PR fixes property-based test by randomizing stake amounts and having exactly the same premine amount for each validator. This ensures that validators have enough native tokens to cover fees on the rootchain and the childchain.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal changed the title Fix test by providing randomized stake amount to different validators Fix TestProperty_DifferentVotingPower by providing randomized stake amount to different validators May 15, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title Fix TestProperty_DifferentVotingPower by providing randomized stake amount to different validators Fix TestProperty_DifferentVotingPower by providing randomized stake amounts May 15, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this May 15, 2023
@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label May 15, 2023
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review May 15, 2023 13:06
@Stefan-Ethernal Stefan-Ethernal requested a review from a team May 15, 2023 13:06
@Stefan-Ethernal Stefan-Ethernal merged commit 72fee88 into develop May 16, 2023
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-648-fix-property-based-test branch May 16, 2023 06:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants