Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-clutter devnet/testnet deployment workflows #1514

Conversation

Stefan-Ethernal
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal commented May 16, 2023

Description

This PR removes the build and push Docker container step from the devnet deployment workflow. Since it is redundant, it also eliminates the unit testing step from the devnet deployment workflows.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label May 16, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this May 16, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title Remove build and push container from devnet deployment workflow De-clutter devnet deployments workflows May 18, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title De-clutter devnet deployments workflows De-clutter devnet/testnet deployment workflows May 18, 2023
@Stefan-Ethernal Stefan-Ethernal merged commit 14611ef into develop May 19, 2023
7 of 8 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-652-remove-build-and-push-container-from-devnet-deployment-workflow branch May 19, 2023 06:28
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants