Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy child chain mintable predicates #1516

Merged
merged 7 commits into from
May 29, 2023
Merged

Deploy child chain mintable predicates #1516

merged 7 commits into from
May 29, 2023

Conversation

Stefan-Ethernal
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal commented May 17, 2023 •
edited

Description

This PR deploys a set of predicate contracts that allow minting tokens on the child chain and depositing to the root chain, meaning that tokens being bridged, originate from the child chain.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Mintable predicates are deployed on the genesis block and the genesis configuration is expanded with predicate addresses.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal self-assigned this May 17, 2023
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-653-deploy-predicates branch 4 times, most recently from 11f7ba3 to e543493 Compare May 19, 2023 06:39
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review May 24, 2023 08:59
@Stefan-Ethernal Stefan-Ethernal requested a review from a team May 24, 2023 08:59
@Stefan-Ethernal Stefan-Ethernal changed the title Introduce mintable predicates Deploy mintable predicates May 24, 2023
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-653-deploy-predicates branch 2 times, most recently from 2f7885a to 3202a8c Compare May 25, 2023 16:59
@Stefan-Ethernal Stefan-Ethernal changed the title Deploy mintable predicates Deploy child chain originated tokens (aka minitable) predicates May 26, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title Deploy child chain originated tokens (aka minitable) predicates Deploy child chain minitable predicates May 26, 2023
@Stefan-Ethernal Stefan-Ethernal added feature New update to Polygon Edge breaking change Functionality that contains breaking changes labels May 26, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title Deploy child chain minitable predicates Deploy child chain mintable predicates May 26, 2023
@Stefan-Ethernal Stefan-Ethernal merged commit a7d36d1 into develop May 29, 2023
10 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-653-deploy-predicates branch May 29, 2023 08:19
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@begmaroman begmaroman begmaroman approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
breaking change Functionality that contains breaking changes feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Stefan-Ethernal @vcastellm @igorcrevar @begmaroman @goran-ethernal