Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate chain-id and supernet-id #1521

Merged

Conversation

goran-ethernal
Copy link
Contributor

@goran-ethernal goran-ethernal commented May 17, 2023

Description

Through this PR we are differentiating chain-id from supernet-id in the genesis file.

Before, chain-id was equal to supernet-id provided by StakeManager when supernet was registered to it in the rootchain deploy command.

Now genesis file will have both chain-id and supernet-id values, where supernet-id will be in the polybftconfig struct in genesis.
chain-id flag in genesis command stays, so that the users can use a custom chain-id for their supernet,

NOTE: supernet-id is not a flag in genesis command, but a value in the genesis file which is populated by the rootchain deploy command when supernet is registered to StakeManager contract.

supernet-id is used for staking, since validators need to provide the supernet id when calling the stakeFor function on StakeManager so that contract knows on which supernet validator is trying to stake.

Commands changed in this PR:

  • stake command - flag chain-id is renamed to supernet-id.

Tagging @DannyS03 to update the docs.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal changed the title Differentiate chain id and supernet id Differentiate chain-id and supernet-id May 17, 2023
@goran-ethernal goran-ethernal self-assigned this May 17, 2023
@goran-ethernal goran-ethernal added the bug fix Functionality that fixes a bug label May 17, 2023
@goran-ethernal goran-ethernal requested a review from a team May 17, 2023 18:25
@goran-ethernal goran-ethernal marked this pull request as ready for review May 17, 2023 18:26
@goran-ethernal goran-ethernal merged commit ed61412 into develop May 18, 2023
8 of 9 checks passed
@goran-ethernal goran-ethernal deleted the EVM-657-Differentiate-chain-id-and-supernet-id branch May 18, 2023 08:33
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2023
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants