Modify rootchain command to use the provided private key to fund validators #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusan-maksimovic
requested review from
vcastellm,
Stefan-Ethernal,
stana-miric and
goran-ethernal
Stefan-Ethernal
approved these changes
May 24, 2023
goran-ethernal
approved these changes
May 24, 2023
dusan-maksimovic
force-pushed
the
EVM-668-root-chain-fund-command-fails-for-any-network-except-local-geth-instance
branch
from
33bab10
to
0b87f43
Compare
dusan-maksimovic
deleted the
EVM-668-root-chain-fund-command-fails-for-any-network-except-local-geth-instance
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue with rootchain fund command when the rootchain is not locally deployed geth instance. If the "private-key" flag is set, then it will be used to sign the transactions to send tokens to validators. Otherwise, validators will be funded by the coinbase account by sending an unsigned transaction, which is only possible with geth instance started in development mode.
Changes include
Checklist
Testing