Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM-671 Fix block tracker WithBlockMaxBacklog for state_sync_relayer #1543

Merged
merged 1 commit into from
May 26, 2023

Conversation

igorcrevar
Copy link
Contributor

Description

If blockMaxBacklog is lower than some default value it should be set to that default value

blockMaxBacklog := e.numBlockConfirmations*2 + 1 
blockTracker := blocktracker.NewBlockTracker(provider.Eth(),   
   blocktracker.WithBlockMaxBacklog(blockMaxBacklog))

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label May 24, 2023
@igorcrevar igorcrevar self-assigned this May 24, 2023
@igorcrevar igorcrevar force-pushed the feature/EVM-671-block-tracker-fix branch 5 times, most recently from b0efda7 to 015fb96 Compare May 24, 2023 10:57
@Nemanja0x
Copy link
Collaborator

Is this one TestE2E_Bridge_ChangeVotingPower unstable?

@goran-ethernal
Copy link
Contributor

Is this one TestE2E_Bridge_ChangeVotingPower unstable?

@Nemanja0x Yes, this PR should fix it: #1520

@igorcrevar igorcrevar force-pushed the feature/EVM-671-block-tracker-fix branch 3 times, most recently from 2c37b48 to bc216ef Compare May 25, 2023 08:32
@igorcrevar igorcrevar force-pushed the feature/EVM-671-block-tracker-fix branch from bc216ef to a7ffecb Compare May 25, 2023 10:56
@igorcrevar igorcrevar merged commit 4f2a67e into develop May 26, 2023
9 checks passed
@igorcrevar igorcrevar deleted the feature/EVM-671-block-tracker-fix branch May 26, 2023 08:50
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants