Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Subnet Genesis Finalize #1545

Merged
merged 2 commits into from
May 26, 2023

Conversation

paulgoleary
Copy link
Collaborator

Description

  • Pulls in upstream fix from ethgo: umbracle/ethgo@7700cae
    Bug in ethgo causes problems with finalize and also elsewhere - the bridge I believe.
  • Changes genesis finalize to allows it to be re-run when the first step has been already been done. This change is not strictly necessary but convenient if the first attempt to finalize fails for some reason.

Please provide a detailed description of what was done in this PR

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just curious, do you remember what was the error message they were getting when running supernet command after it was initialized?

Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vcastellm
Copy link
Contributor

Can you rebase @paulgoleary ?

@Stefan-Ethernal Stefan-Ethernal force-pushed the poleary/fix-subnet-genesis-finalize branch from 3e68e0c to 86ff411 Compare May 26, 2023 08:44
@Stefan-Ethernal
Copy link
Contributor

Can you rebase @paulgoleary ?

@vcastellm @paulgoleary FYI, I've rebased. If CI is 🟢, we can merge it.

@Stefan-Ethernal Stefan-Ethernal merged commit 3975cef into develop May 26, 2023
8 of 9 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the poleary/fix-subnet-genesis-finalize branch May 26, 2023 10:00
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants