Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write minValidatorCount to genesis.json #1547

Conversation

jp-imx
Copy link
Contributor

@jp-imx jp-imx commented May 24, 2023

Description

Re-open from this: #1535 (comment)

Write the value from the genesis '--min-validator-count' flag to the genesis.json output

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

I ran the following command and verified the file:

./polygon-edge genesis --block-gas-limit 10000000 --epoch-size 10 \                                     
--validators-path ./ --validators-prefix test-chain- \
--consensus polybft \
--reward-wallet ... \
--transactions-allow-list-admin ... \
--transactions-allow-list-enabled ... \
--block-gas-limit ... \
--block-time ... \
--min-validator-count 3 \
--max-validator-count 100

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

jp-imx and others added 2 commits May 23, 2023 09:51
Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
@jp-imx
Copy link
Contributor Author

jp-imx commented May 24, 2023

@goran-ethernal I didn't have access to re-open 1535 so I re-created it here.

@Stefan-Ethernal Stefan-Ethernal requested a review from a team May 25, 2023 05:35
@jp-imx
Copy link
Contributor Author

jp-imx commented May 29, 2023

@goran-ethernal / @igorcrevar thank you for reviewing these changes. I would appreciate your help with the next steps.

The "Pull Request CI / Test / Polygon Edge (pull_request)" check failed, but it seems to me like it's unrelated to the changes here. Also, I don't have access to merging this PR when we deem it ready.

@goran-ethernal goran-ethernal merged commit 44bbefc into 0xPolygon:develop May 29, 2023
15 of 16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants