Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM-665 No Log Bloom #1550

Merged
merged 4 commits into from
May 25, 2023
Merged

EVM-665 No Log Bloom #1550

merged 4 commits into from
May 25, 2023

Conversation

igorcrevar
Copy link
Contributor

Description

The log query will consume too much CPU and I/O especially with many DAPPs query all together.

Demo
Transactions with a log in block never get a bloom filter.

Transaction:

 [Transaction 0xe46e151d633637dee3425712b81935ab933b54c489eaa9fd630b3a83f75f62aa - Polygon EdgeNet Explorer](https://explorer-edgenet.polygon.technology/tx/0xe46e151d633637dee3425712b81935ab933b54c489eaa9fd630b3a83f75f62aa/logs) 

Query: curl -H 'Content-Type: application/json' -X POST

https:[//rpc-edgenet.polygon.technology](https://rpc-edgenet.polygon.technology/) -d '{"id": 0, "jsonrpc":"2.0", "method": "eth_getBlockByNumber", "params": ["8163744", false]}'

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

consensus/polybft/block_builder_test.go Outdated Show resolved Hide resolved
consensus/polybft/block_builder_test.go Show resolved Hide resolved
consensus/polybft/block_builder_test.go Outdated Show resolved Hide resolved
@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label May 25, 2023
@igorcrevar igorcrevar merged commit 7b1f128 into develop May 25, 2023
6 checks passed
@igorcrevar igorcrevar deleted the feature/EVM-665-No_log-Bloom branch May 25, 2023 13:38
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants