Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy contract deployment whitelisting mechanism #1556

Conversation

Stefan-Ethernal
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal commented May 26, 2023

Description

This PR removes the legacy smart contract deployment whitelisting mechanism, delivered through #692, since in the meantime there is a completely new allowlist and blocklist mechanism for contracts deployment, transactions execution as well as performing bridge transactions.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Genesis configuration is changed, whitelists parameter is removed from chain.params in the genesis.json.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal self-assigned this May 26, 2023
@Stefan-Ethernal Stefan-Ethernal added the breaking change Functionality that contains breaking changes label May 26, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team May 26, 2023 11:00
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review May 26, 2023 11:00
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stefan-Ethernal Stefan-Ethernal merged commit 6ff53be into develop May 29, 2023
10 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-585-revert-existing-contracts-deployment-whitelisting-mechanism branch May 29, 2023 12:14
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change Functionality that contains breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants