Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eth_getStorageAt always returning 0 #1558

Merged
merged 2 commits into from
May 26, 2023
Merged

Fix eth_getStorageAt always returning 0 #1558

merged 2 commits into from
May 26, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented May 26, 2023 •
edited
Loading

Description

This is a continuation of #1546 PR, which just fixes unit tests.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label May 26, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this May 26, 2023
@Stefan-Ethernal Stefan-Ethernal mentioned this pull request May 26, 2023
Merged
11 tasks
@Stefan-Ethernal Stefan-Ethernal linked an issue May 26, 2023 that may be closed by this pull request
eth_getStorageAt returns 0 #1447
Closed
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review May 26, 2023 11:14
@Stefan-Ethernal Stefan-Ethernal requested a review from a team May 26, 2023 11:14
@Stefan-Ethernal Stefan-Ethernal merged commit c2f643f into develop May 26, 2023
7 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-522-get-storage-should-return-parsed-data branch May 26, 2023 15:27
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@begmaroman begmaroman begmaroman approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eth_getStorageAt returns 0
5 participants
@Stefan-Ethernal @vcastellm @begmaroman @goran-ethernal @typestring