Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise and fix cluster script when ran in docker mode #1571

Merged
merged 7 commits into from
Jun 1, 2023
Merged

Revise and fix cluster script when ran in docker mode #1571

merged 7 commits into from
Jun 1, 2023

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented May 31, 2023 •
edited

Description

Revise and fix cluster script when ran in docker mode

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@begmaroman begmaroman self-assigned this May 31, 2023
@begmaroman begmaroman added the bug fix Functionality that fixes a bug label May 31, 2023
Stefan-Ethernal
Stefan-Ethernal reviewed May 31, 2023
View reviewed changes
command/rootchain/supernet/stakemanager/stake_manager_deploy.go Outdated Show resolved Hide resolved
command/rootchain/supernet/stakemanager/stake_manager_deploy.go Outdated Show resolved Hide resolved
docker/local/polygon-edge.sh Outdated Show resolved Hide resolved
docker/local/polygon-edge.sh Outdated Show resolved Hide resolved
docker/local/polygon-edge.sh Outdated Show resolved Hide resolved
@Stefan-Ethernal
Copy link
Contributor

Also thinking out loud… does it make sense and is it feasible merging ‘polygon-edge.sh’ and ‘cluster’ script into the one?

@Stefan-Ethernal Stefan-Ethernal linked an issue Jun 1, 2023 that may be closed by this pull request
Polygon Supernets Docker Build Fails for v0.8.1 and v0.9.0 #1518
Closed
@begmaroman begmaroman merged commit 3b827b8 into develop Jun 1, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
@begmaroman begmaroman deleted the feature/EVM-593 branch June 1, 2023 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal Awaiting requested review from goran-ethernal

Assignees

@begmaroman begmaroman

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Polygon Supernets Docker Build Fails for v0.8.1 and v0.9.0
3 participants
@begmaroman @Stefan-Ethernal @vcastellm