Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ACL admins to remove themselves #1578

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

vcastellm
Copy link
Contributor

Description

This PR implements a protection to ACLs so going forward an admin can not remove himself from the admins list, it should be removed by another admin.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@vcastellm vcastellm self-assigned this Jun 1, 2023
@vcastellm vcastellm added the feature New update to Polygon Edge label Jun 1, 2023
@vcastellm vcastellm marked this pull request as ready for review June 1, 2023 14:40
@vcastellm vcastellm requested a review from a team June 1, 2023 16:22
@QEDK
Copy link

QEDK commented Jun 2, 2023

This PR implements a protection to ACLs so going forward an admin can not remove himself from the admins list, it should be removed by another admin.

The admin should not be able to remove themselves when there's only one admin, otherwise I think they should be able to remove themselves, no?

Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note, @QEDK's comment makes sense as well.

@vcastellm
Copy link
Contributor Author

vcastellm commented Jun 2, 2023

The admin should not be able to remove themselves when there's only one admin, otherwise I think they should be able to remove themselves, no?

We can not count how many admins there are in the lists due to limitation of the state. This was the first idea but we needed to adapt it to this.

@vcastellm vcastellm merged commit d230546 into develop Jun 2, 2023
7 checks passed
@vcastellm vcastellm deleted the EVM-649-check-ac-ls-edge-cases branch June 2, 2023 13:15
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants