Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM-523 Fix race condition in gas estimation #1583

Merged

Conversation

igorcrevar
Copy link
Contributor

Description

Resolve TODO in TestEth_EstimateGas_GasLimit (jsonrpc/eth_state_test.go) by fixing the race condition caused by gas estimation (EstimateGas function).

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label Jun 2, 2023
@igorcrevar igorcrevar self-assigned this Jun 2, 2023
@igorcrevar igorcrevar merged commit da4ffe1 into develop Jun 2, 2023
5 of 6 checks passed
@igorcrevar igorcrevar deleted the feature/EVM-523-Fixraceconditioningasestimation branch June 2, 2023 14:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants